Forwarded: Re: Status of next perl tk release?

[lvirden@xxxxxxx (Larry W. Virden)]

If anyone would like to see the behavior of MultiFileSelect wrapped into
Tk 8.x, here is the release maintainers comments on what needs to occur
to get that to happen.  Anyone have time to work on this?
Forwarded mail follows:
>From nick@xxxxxxxxxxxxxx  Thu Oct 29 14:04:44 1998
Date: Thu, 29 Oct 1998 19:04:43 GMT
Message-Id: <199810291904.TAA00759@xxxxxxxxxxxxxx>
Content-Disposition: inline
X-Mailer: tkmail-0.011/Perl5 Mail::Internet v1.30
In-Reply-To: <9810291304.AA4616@xxxxxxx> from Larry W Virden on Thu,    29 Oct 1998 13:04:26 -0500 (EST)
Subject: Re: Status of next perl tk release?
References: <9810291304.AA4616@xxxxxxx>
To: lvirden
Cc: ptk@xxxxxxxxxxxxxxxxxx
Sender: Nick Ing-Simmons <nick@xxxxxxxxxxxxxx>
>From: Nick Ing-Simmons <nick@xxxxxxxxxxxxxx>
Reply-To: Nick Ing-Simmons <nick@xxxxxxxxxxxxxx>
content-length: 2209
Status: RO

Larry W Virden <lvirden@xxxxxxx> writes:
>From: Nick Ing-Simmons <nik@xxxxxxxxxxx>
>> That looks like Tk::MultiFileSelect is a 'pilotmgr' custom widget. 
>> It is certainly not one I am familiar with and yet another FileSelect is not what 
>> we need :-(.
>
>Actually, MultiFileSelect is a slight modification of the standard fileselect
>widget, which permits one to select more than one file at a time.

So why was it not submitted as a patch to FileSelect with a new configure 
option to enable the behaviour?  Or alternativley why is it not implemented as
a widget which inherited from FileSelect ?

package Tk::MultiSelect;
@ISA = qw(Tk::FileSelect);

sub Populate
{
 my ($self,$args) = @_;
 $cw->SUPER::Populate($args); 
 # add AcceptAll button 
}

sub AcceptAll
{
}

1;
__END__

>
>Here is the diff between the MultiFileSelect and the current Tk::FileSelect.
>Is there a way that perhaps this functionality could make it's way into
>Tk::FileSelect?

Of course - submit a patch relative to current one. The diff you sent does
not satisfy this criterion as it backs out all the changes since Tk40? version
on which it was based - and as you have observed -  breaks it.

If someone submits a test script for MultiSelect I can probably sort out 
the diff.

>@@ -61,6 +182,6 @@
>           $so == $cw->Subwidget('dir_list')->Subwidget('listbox')) {
>-        $leaves = [$cw->Subwidget('dir_list')->getSelected];
>+        $leaves = [$cw->Subwidget('dir_list')->Getselected];

That or similar changes below is probably root-cause of the breakage.
>-    $b->bind('<Double-Button-1>' => [$w => 'Accept_dir', Ev(['getSelected'])]);
>+    $b->bind('<Double-Button-1>' => [$w => 'Accept_dir', Ev(['Getselected'])]);
> 
>@@ -181,2 +306,4 @@
>     $b->pack(-side => 'top', -fill => 'x', -expand => 1);
>+    $b = $f->Button('-text' => 'Accept All', -command => [ 'SelectAll', $w ]);
>+    $b->pack(-side => 'top', -fill => 'x', -expand => 1);

>+
>+ # If the selected directory is "..", strip off the last directory and the
>+ # ".." (no need to keep the ".." in the path)
>+ $dir =~ s#(.*)/.*/\.\.#$1# if ($dir =~ /\.\.$/);

Hmm, that can lead to strang behaviour relating to symbolic links.
-- 
Nick Ing-Simmons


-- 
Larry W. Virden                 INET: lvirden@xxxxxxx
<URL:http://www.purl.org/NET/lvirden/> <*> O- "We are all Kosh."
Unless explicitly stated to the contrary, nothing in this posting should 
be construed as representing my employer's opinions.
------------------------------------------------------------------------
***********************************************************
*             This is a public mailing list!              *
* Please do not publish Sun proprietary information here! *
*        -  -  -  -  -  -  -  -  -  -  -  -  -  -         *
*             http://www.moshpit.org/pilotmgr             *
***********************************************************